Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not compatible with asterisk 16 #17

Open
slesru opened this issue Oct 12, 2018 · 2 comments
Open

not compatible with asterisk 16 #17

slesru opened this issue Oct 12, 2018 · 2 comments

Comments

@slesru
Copy link

slesru commented Oct 12, 2018

Hello!

Previously asterisk sent --END command

action_command_cleanup:

    close(fd);
    unlink(template);
    astman_append(s, "--END COMMAND--\r\n\r\n");
    
    ast_free(buf);
    ast_free(final_buf);

which php-agi waits for

while(substr($buff, 0, 6) != '--END ')

but now there is no such code

action_command_cleanup:
astman_append(s, "\r\n");

    close(fd);
    unlink(template);

    ast_free(buf);
    ast_free(final_buf);

So php-agi does not work with asterisk 16.. :-(

@FreeSS
Copy link
Contributor

FreeSS commented Oct 12, 2018

thanks for the note 👍

@FreeSS
Copy link
Contributor

FreeSS commented Jun 11, 2019

@slesru Hello! We made changes to support the new version of the asterisk, do you have the opportunity to test the operation of the new code on the 16th version? Changes are in PR #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants