From b3ef23f305736ce5c784026e163796c11497b6f9 Mon Sep 17 00:00:00 2001
From: Mohammed Alotaibi <Awiteb@pm.me>
Date: Mon, 12 Feb 2024 20:46:48 +0300
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(i18n):=20reverse=20arrows=20?=
 =?UTF-8?q?in=20RTL=20languages=20(#272)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: welpo <welpo@users.noreply.github.com>
---
 sass/parts/_misc.scss            | 11 +++++++++++
 static/feed_style.xsl            |  2 +-
 templates/macros/list_posts.html |  4 ++--
 templates/page.html              |  6 +++---
 templates/partials/paginate.html |  8 ++++----
 templates/tags/single.html       |  2 +-
 templates/taxonomy_single.html   |  2 +-
 7 files changed, 23 insertions(+), 12 deletions(-)

diff --git a/sass/parts/_misc.scss b/sass/parts/_misc.scss
index fb77d85da..1a6dc370d 100644
--- a/sass/parts/_misc.scss
+++ b/sass/parts/_misc.scss
@@ -212,3 +212,14 @@ details summary {
         }
     }
 }
+
+:dir(rtl) .arrow {
+    display: inline-block;
+    transform: rotate(180deg);
+}
+
+// This for the arrows that point to a corner, (e.g. '↗', '↘', '↙', '↖')
+:dir(rtl) .arrow-corner {
+    display: inline-block;
+    transform: rotate(270deg);
+}
diff --git a/static/feed_style.xsl b/static/feed_style.xsl
index a36aa4ae4..9d7ad6a69 100644
--- a/static/feed_style.xsl
+++ b/static/feed_style.xsl
@@ -42,7 +42,7 @@
               <xsl:attribute name="href">
                 <xsl:value-of select="/atom:feed/atom:link[2]/@href"/>
               </xsl:attribute>
-            <xsl:value-of select="/atom:feed/str:translations/str:visit_the_site" /> →</a><p></p>
+            <xsl:value-of select="/atom:feed/str:translations/str:visit_the_site" />&#160;<span class="arrow">→</span></a><p></p>
             </section>
 
             <div class="padding-top listing-title bottom-divider">
diff --git a/templates/macros/list_posts.html b/templates/macros/list_posts.html
index b61d0a3fc..d0f2fcc78 100644
--- a/templates/macros/list_posts.html
+++ b/templates/macros/list_posts.html
@@ -39,14 +39,14 @@ <h2 class="bloglist-title">
                         <p>{{ post.summary | striptags | safe | trim_end_matches(pat=".") }}…</p>
                     {% endif %}
                 </div>
-                <a class="readmore" href={{ post.permalink }}>{{ macros_translate::translate(key="read_more", default="Read more", language_strings=language_strings) }}&nbsp;→</a>
+                <a class="readmore" href={{ post.permalink }}>{{ macros_translate::translate(key="read_more", default="Read more", language_strings=language_strings) }}&nbsp;<span class="arrow">→</span></a>
             </div>
         </section>
     {% endif %}
         {% if not loop.last %}
             {% if loop.index == max %}
                 <div class="all-posts">
-                    <a href="{{ get_url(path="blog", lang=lang) }}/">{{ macros_translate::translate(key="all_posts", default="All posts", language_strings=language_strings) }}&nbsp;⟶</a>
+                    <a href="{{ get_url(path="blog", lang=lang) }}/">{{ macros_translate::translate(key="all_posts", default="All posts", language_strings=language_strings) }}&nbsp;<span class="arrow">⟶</span></a>
                 </div>
             {% endif %}
         {% endif %}
diff --git a/templates/page.html b/templates/page.html
index b27c29201..b33ed7770 100644
--- a/templates/page.html
+++ b/templates/page.html
@@ -88,7 +88,7 @@ <h1 class="article-title">
                 {# Show link to remote changes if enabled #}
                 {% if config.extra.remote_repository_url and macros_settings::evaluate_setting_priority(setting="show_remote_changes", page=page, default_global_value=true) == "true" %}
                     {{ separator }}
-                    <li><a href="{% include "partials/history_url.html" %}" {{ blank_target }} rel="{{ rel_attributes }}">{{ macros_translate::translate(key="see_changes", default="See changes", language_strings=language_strings) }}<small> ↗</small></a></li>
+                    <li><a href="{% include "partials/history_url.html" %}" {{ blank_target }} rel="{{ rel_attributes }}">{{ macros_translate::translate(key="see_changes", default="See changes", language_strings=language_strings) }}<small>&nbsp;<span class="arrow-corner">↗</span></small></a></li>
                 {% endif %}
             {% endif %}
         </ul>
@@ -165,13 +165,13 @@ <h3>TL;DR:</h3>
             <nav class="{{ full_width_class | default(value="") }} article-navigation">
                 <div>
                 {%- if left_link and left_label and left_title -%}
-                <a href="{{ left_link | safe }}" aria-label="{{ left_label }}" aria-describedby="left_title">← {{ left_label }}</a>
+                <a href="{{ left_link | safe }}" aria-label="{{ left_label }}" aria-describedby="left_title"><span class="arrow">←</span>&nbsp;{{ left_label }}</a>
                 <p aria-hidden="true" id="left_title">{{ left_title | truncate(length=100, end="…") }}</p>
                 {%- endif -%}
                 </div>
                 <div>
                 {%- if right_link and right_label and right_title -%}
-                <a href="{{ right_link | safe }}" aria-label="{{ right_label }}" aria-describedby="right_title">{{ right_label }} →</a>
+                <a href="{{ right_link | safe }}" aria-label="{{ right_label }}" aria-describedby="right_title">{{ right_label }}&nbsp;<span class="arrow">→</span></a>
                 <p aria-hidden="true" id="right_title">{{ right_title | truncate(length=100, end="…") }}</p>
                 {%- endif -%}
                 </div>
diff --git a/templates/partials/paginate.html b/templates/partials/paginate.html
index 2d488eeda..1833dca5b 100644
--- a/templates/partials/paginate.html
+++ b/templates/partials/paginate.html
@@ -2,11 +2,11 @@
     <ul class="pagination">
         {% if paginator.previous %}
             <li class="page-item page-prev">
-                <a href="{{ paginator.previous }}" class="page-link" aria-label="{{ macros_translate::translate(key="prev", default="Prev", language_strings=language_strings) }}">← {{ macros_translate::translate(key="prev", default="Prev", language_strings=language_strings) }}</a>
+                <a href="{{ paginator.previous }}" class="page-link" aria-label="{{ macros_translate::translate(key="prev", default="Prev", language_strings=language_strings) }}"><span class="arrow">←</span> {{ macros_translate::translate(key="prev", default="Prev", language_strings=language_strings) }}</a>
             </li>
         {% else %}
             <li class="page-item page-prev">
-                <span class="page-link disabled" aria-disabled="true" aria-label="{{ macros_translate::translate(key="prev", default="Prev", language_strings=language_strings) }} (disabled)">← {{ macros_translate::translate(key="prev", default="Prev", language_strings=language_strings) }}</span>
+                <span class="page-link disabled" aria-disabled="true" aria-label="{{ macros_translate::translate(key="prev", default="Prev", language_strings=language_strings) }} (disabled)"><span class="arrow">←</span> {{ macros_translate::translate(key="prev", default="Prev", language_strings=language_strings) }}</span>
             </li>
         {% endif %}
 
@@ -16,11 +16,11 @@
 
         {% if paginator.next %}
             <li class="page-item page-next">
-                <a href="{{ paginator.next }}" class="page-link" aria-label="{{ macros_translate::translate(key="next", default="Next", language_strings=language_strings) }}">{{ macros_translate::translate(key="next", default="Next", language_strings=language_strings) }} →</a>
+                <a href="{{ paginator.next }}" class="page-link" aria-label="{{ macros_translate::translate(key="next", default="Next", language_strings=language_strings) }}">{{ macros_translate::translate(key="next", default="Next", language_strings=language_strings) }} <span class="arrow">→</span></a>
             </li>
         {% else %}
             <li class="page-item page-next">
-                <span class="page-link disabled" aria-disabled="true" aria-label="{{ macros_translate::translate(key="next", default="Next", language_strings=language_strings) }} (disabled)">{{ macros_translate::translate(key="next", default="Next", language_strings=language_strings) }} →</span>
+                <span class="page-link disabled" aria-disabled="true" aria-label="{{ macros_translate::translate(key="next", default="Next", language_strings=language_strings) }} (disabled)">{{ macros_translate::translate(key="next", default="Next", language_strings=language_strings) }} <span class="arrow">→</span></span>
             </li>
         {% endif %}
     </ul>
diff --git a/templates/tags/single.html b/templates/tags/single.html
index d36ba2a63..29d6158f7 100644
--- a/templates/tags/single.html
+++ b/templates/tags/single.html
@@ -9,7 +9,7 @@
 
 <ul class="pagination">
     <li class="page-item">
-        <a class="all-tags" href="{{ get_url(path="tags", lang=lang) }}/">←&nbsp;{{- macros_translate::translate(key="all_tags", default="All tags", language_strings=language_strings) -}}</a>
+        <a class="all-tags" href="{{ get_url(path="tags", lang=lang) }}/"><span class="arrow">←</span>&nbsp;{{- macros_translate::translate(key="all_tags", default="All tags", language_strings=language_strings) -}}</a>
     </li>
 </ul>
 
diff --git a/templates/taxonomy_single.html b/templates/taxonomy_single.html
index a18201b2c..bce132a1f 100644
--- a/templates/taxonomy_single.html
+++ b/templates/taxonomy_single.html
@@ -9,7 +9,7 @@
 
 <ul class="pagination">
     <li class="page-item">
-        <a class="all-tags" href="{{ get_url(path="tags", lang=lang) }}/">←&nbsp;{{- macros_translate::translate(key=taxonomy.name, default=taxonomy.name, language_strings=language_strings) -}}</a>
+        <a class="all-tags" href="{{ get_url(path="tags", lang=lang) }}/"><span class="arrow">←</span>&nbsp;{{- macros_translate::translate(key=taxonomy.name, default=taxonomy.name, language_strings=language_strings) -}}</a>
     </li>
 </ul>