Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compilaton with Go 1.23 #118

Closed
yorickdowne opened this issue Aug 14, 2024 · 2 comments · Fixed by #122
Closed

Support compilaton with Go 1.23 #118

yorickdowne opened this issue Aug 14, 2024 · 2 comments · Fixed by #122

Comments

@yorickdowne
Copy link

Feature

Compilation with Go 1.23 currently fails. Compilation with Go 1.22 works.

171.8 github.com/ethereum/go-ethereum/cmd/gwemix
172.2 # github.com/ethereum/go-ethereum/cmd/gwemix
172.2 link: github.com/fjl/memsize: invalid reference to runtime.stopTheWorld
172.3 util.go:47: exit status 1
172.3 exit status 1
172.3 make: *** [Makefile:47: gwemix] Error 1
@yorickdowne
Copy link
Author

Upstream: fjl/memsize#5

@yorickdowne
Copy link
Author

Go team rejected the memsize author’s proposal to make memsize work with Go 1.23.

Upstream go-ethereum fixed this by removing memsize in this patch: ethereum@e467577

This was referenced Aug 29, 2024
@jed-wemade jed-wemade linked a pull request Sep 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants