From 823b8ac1b3ba0dc817a10f1ad1cb1830560a8576 Mon Sep 17 00:00:00 2001 From: Ilya Lesikov Date: Thu, 21 Mar 2024 20:49:24 +0300 Subject: [PATCH] fix: Jobs not failing on errors Signed-off-by: Ilya Lesikov --- pkg/trackers/dyntracker/statestore/readiness_task_state.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/trackers/dyntracker/statestore/readiness_task_state.go b/pkg/trackers/dyntracker/statestore/readiness_task_state.go index fd58049..88a7223 100644 --- a/pkg/trackers/dyntracker/statestore/readiness_task_state.go +++ b/pkg/trackers/dyntracker/statestore/readiness_task_state.go @@ -212,8 +212,6 @@ func initReadinessTaskStateFailureConditions(failMode multitrack.FailMode, total }) if failMode != multitrack.IgnoreAndContinueDeployProcess { - maxErrors := lo.Max([]int{totalAllowFailuresCount + 1}) - failureConditions = append(failureConditions, func(taskState *ReadinessTaskState) bool { var totalErrsCount int lo.Must0(domigraph.BFS(taskState.resourceStatesTree, util.ResourceID(taskState.name, taskState.namespace, taskState.groupVersionKind), func(id string) bool { @@ -231,7 +229,7 @@ func initReadinessTaskStateFailureConditions(failMode multitrack.FailMode, total return false })) - return totalErrsCount > maxErrors + return totalErrsCount > totalAllowFailuresCount }) }