-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: logging "err:" without any context #2400
Comments
I am seeing this as well in the latest version. I have a |
Hmm, seems you can't just pass an error object to the error log method, it has to be a string :( |
Any updates on this? I need JSON format because the simple format doesn't output objects properly. |
If it’s an issue that the error object has to be a string, maybe make a pr that allows it to be an Error or a string? That would probably be easy and backward compatible and not hurt performance materially |
I really wish I had time to contribute to libraries like this. I should probably try and make the effort seeing how much I complain about things but sadly I'm too busy with programming for work that contributing simply isn't cost/time effective currently. Being brutally honest, something like this, I expect to work out of the box. JSON formatting shoukd be able to handle error objects. |
@paul-uz I am testing this now but am able to get an error message with a Json response. What block of code are you using to get this issue? |
🔎 Search Terms
error logging
The problem
we utilize
ddLogger.info
andddLogger.error
.We transport to our Datadog instance.
In Datadog we're receiving tons of logs that are just "err:".
Where could they be coming from?
What version of Winston presents the issue?
3.9.0
What version of Node are you using?
v16.18.1
If this worked in a previous version of Winston, which was it?
No response
Minimum Working Example
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: