Skip to content

typecheck-tests is at 155 errors / 48 files and growing — fix the ServiceToken shape and put it in CI #321

Description

@sroussey

The script is not in CI and the documented count is three measurements stale.

when errors
CLAUDE.md (as written) 122
PR #311, 2026-08-20 140
dd11d316, today 155 across 48 files

bun run build and bun run test both pass over these files, so nothing else type-checks them — which is exactly the condition CLAUDE.md describes and then does not act on.

Dominant shape (~40 of the 48 files, all src/cli/queries/*.test.ts): a test helper hands ServiceToken<CrowdfundingRepositoryStorage> where an ITabularStorage is expected, so every .put() on it errors. One helper fix should clear the bulk.

Others worth separating out:

  • DbStatus.test.ts:143 passes an updateProgress mock returning number where void | Promise<void> is required.
  • A spac_candidate fixture omits the signal_filed_sic_6770 column added last window — a real near-miss, not a typing artifact.

Plan:

  1. fix the helper;
  2. sweep the remainder;
  3. add bun run typecheck-tests to test.yml between format-check and build;
  4. update the CLAUDE.md paragraph to say it is in CI, rather than describing the conditions under which it would be.

Found during the 2026-08-24 review. Snapshot: workglow-dev/prdanalysis/grades/2026-08-24/sec-detailed.md.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions