From 241f3fdc0e7ade49f10bc104983ec0115793344b Mon Sep 17 00:00:00 2001 From: Tharsanan1 Date: Thu, 28 Mar 2024 11:59:10 +0530 Subject: [PATCH] Improve code --- .../internal/operator/controllers/dp/api_controller.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/adapter/internal/operator/controllers/dp/api_controller.go b/adapter/internal/operator/controllers/dp/api_controller.go index d98a9394af..591a79db23 100644 --- a/adapter/internal/operator/controllers/dp/api_controller.go +++ b/adapter/internal/operator/controllers/dp/api_controller.go @@ -101,7 +101,7 @@ type APIReconciler struct { successChannel *chan synchronizer.SuccessEvent statusUpdater *status.UpdateHandler mgr manager.Manager - controlPlaneEnabled bool + apiPropagationEnabled bool } // NewAPIController creates a new API controller instance. API Controllers watches for dpv1alpha2.API and gwapiv1b1.HTTPRoute. @@ -123,7 +123,7 @@ func NewAPIController(mgr manager.Manager, operatorDataStore *synchronizer.Opera } conf := config.ReadConfigs() - apiReconciler.controlPlaneEnabled = conf.Adapter.ControlPlane.EnableAPIPropagation + apiReconciler.apiPropagationEnabled = conf.Adapter.ControlPlane.EnableAPIPropagation predicates := []predicate.Predicate{predicate.NewPredicateFuncs(utils.FilterByNamespaces(conf.Adapter.Operator.Namespaces))} if err := c.Watch(source.Kind(mgr.GetCache(), &dpv1alpha2.API{}), &handler.EnqueueRequestForObject{}, @@ -249,7 +249,7 @@ func (apiReconciler *APIReconciler) Reconcile(ctx context.Context, req ctrl.Requ if err := apiReconciler.client.Get(ctx, req.NamespacedName, &apiCR); err != nil { apiState, found := apiReconciler.ods.GetCachedAPI(req.NamespacedName) if found && k8error.IsNotFound(err) { - if apiReconciler.controlPlaneEnabled { + if apiReconciler.apiPropagationEnabled { // Convert api state to api cp data loggers.LoggerAPKOperator.Info("Sending API deletion event to agent") apiCpData := apiReconciler.convertAPIStateToAPICp(ctx, apiState) @@ -430,7 +430,7 @@ func (apiReconciler *APIReconciler) resolveAPIRefs(ctx context.Context, api dpv1 loggers.LoggerAPKOperator.Debugf("Child references are retrieved successfully for API CR %s", apiRef.String()) if !api.Status.DeploymentStatus.Accepted { - if apiReconciler.controlPlaneEnabled { + if apiReconciler.apiPropagationEnabled { // Publish the api data to CP apiCpData := apiReconciler.convertAPIStateToAPICp(ctx, *apiState) apiCpData.Event = controlplane.EventTypeCreate @@ -442,7 +442,7 @@ func (apiReconciler *APIReconciler) resolveAPIRefs(ctx context.Context, api dpv1 return &synchronizer.APIEvent{EventType: constants.Create, Events: []synchronizer.APIState{*apiState}, UpdatedEvents: []string{}}, nil } else if cachedAPI, events, updated := apiReconciler.ods.UpdateAPIState(apiRef, apiState); updated { - if apiReconciler.controlPlaneEnabled { + if apiReconciler.apiPropagationEnabled { // Publish the api data to CP apiCpData := apiReconciler.convertAPIStateToAPICp(ctx, *apiState) apiCpData.Event = controlplane.EventTypeUpdate