Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to skip waitForFocus #4

Open
marekchovanec opened this issue May 5, 2022 · 1 comment
Open

Option to skip waitForFocus #4

marekchovanec opened this issue May 5, 2022 · 1 comment

Comments

@marekchovanec
Copy link

Thanks for a great solution for taking screenshots! I have a small feature request - is it necessary to always call waitForFocus before taking a screenshot?

When taking a screenshot of the full screen, it's not obvious that you need to click back into the browser window to get focus and take a screenshot.

I briefly tested a modified version and the screenshot is taken correctly even when I choose full screen (without waiting for focus).

Can you please add an option to skip this waitForFocus call?
@TejasQ
Copy link
Contributor

TejasQ commented Jul 2, 2022

Sure! Or since it's open source, maybe you want to? I'm happy to guide you in the PR if you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TejasQ @marekchovanec