Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction value property can be null but it's not compatible with some EVM Wallets #147

Open
redDwarf03 opened this issue May 17, 2024 · 0 comments

Comments

@redDwarf03
Copy link

Hello

The transaction's value is null by default.
For example, Phantom wallet send an RPC error "got code 9991 with msg "Missing or invalid parameters" when value is null.
We should send EtherAmount.zero instead of null

Do you think it will be ok to replace null to 0 by default ? Any impact with other wallet ?

I precise i use for example eth_sendTransaction with a Transaction.value = null to create HTLC Contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant