-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The plugin Xi/Tweaks should not disable the use of the arrow keys of the message window when a tab-title has focus #58
Comments
I took a look at the plugin. I think the following code excerpt is responsible. However, I recall it was added at your request to try to focus the contents of the tab when the tab bar is clicked. I am willing to remove it, but if so, would definitely not add it back in the future. Consider the attempts to change focus to the tab contents to be a failure.
I think you're the only user of the xitweaks plugin. I can upload the source to another repo. Then once you figure out how to build it, you'll be able to experiment with making changes on your own. |
Since #15 was closed, it is better to solve the problem upstream, is it geany or gtk. So, you can remove all code that is trying to set the focus on the content-area of the tab when clicking on the tab-title, is it the plugin
I would experiment it if I would understand how to code software. But I don't. |
You were able to modify Lua scripts, so you could probably figure it out. It's mostly searching documentation to find functions that might accomplish what you want. I'll put the code in another repo after removing the code that attempts to change focus and updating the build system. |
I requested many things. And I'm so thankful that you solved most of them and tried to solve the rest. But if code does not work, just remove it. I never asked to keep code inside the plugins |
You're welcome. I was mainly clarifying that, since past attempts to change focus have been unsuccessful, so I'm giving up. It's been a while since I've looked at the xi-tweaks plugin... looks like it has code to provide a shortcut and allow tabs to be styled with css. I'd like to change the name to something that better fits what it does. Any suggestions? BTW: The code I pasted earlier seems (at least partly) to be necessary to allow css styles. I haven't looked for the part that changes focus yet. |
At the moment I use the plugin
In issue number 59 with the title
If you put the five shortcuts in the plugin |
Could you please remove the non-working focus-code of the plugin |
I don't know where to report the issue about the plugin Xi/Tweaks, so I report it here within the plugin Preview.
When the plugin Xi/Tweaks is deactivated, sidebar and message window have exactly the same behavior:
When the plugin Xi/Tweaks is activated, the behavior of the sidebar will not change, but the behavior of the message window:
Possible solution
I can imagine that there is code that tries to put the focus on the content-area of a tab. And I think that this disturbs the normal behavior of the message window.
History
I recognized yesterday the issue at geany with the issue number 3961 with the title:
BUG: A release of a click on a tab-title of the sidebar does not put always the content-area of the tab in focus
.The text was updated successfully, but these errors were encountered: