Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UUID as a part of SimpleEvent #61

Open
kristinapathak opened this issue Mar 25, 2021 · 2 comments
Open

Add UUID as a part of SimpleEvent #61

kristinapathak opened this issue Mar 25, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@kristinapathak
Copy link
Contributor

Currently, glaukos is utilizing a bug in Caduceus in order to skip over an event in the event history that is the same event sent to the webhook. The transaction UUID is meant to be no longer be set/created in Caduceus as a part of this Caduceus issue:
xmidt-org/caduceus#174 (comment)

A UUID is helpful for identifying events. It would be nice to add it as a required field to SimpleEvent in some form, even if TransactionUUID doesn't make sense.
@kristinapathak kristinapathak added the enhancement New feature or request label Mar 25, 2021
@schmidtw
Copy link
Member

I agree, I think excluding the TransactionUUID was a mistake in the SimpleEvent. We'll need to rev the spec to add this.

@kristinapathak
Copy link
Contributor Author

This would implement the change in the spec described in xmidt-org/docs#74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schmidtw @kristinapathak