Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing C API #12

Open
mbanth opened this issue Jan 20, 2021 · 1 comment
Open

Missing C API #12

mbanth opened this issue Jan 20, 2021 · 1 comment
Labels
type:enhancement New feature or request

Comments

@mbanth
Copy link

mbanth commented Jan 20, 2021

The api/random.h header file defines a REFERENCE_PARAM macro to define some function parameters as either C pointers or XC references. In this way, the repository sets itself up to support a C API.

However, the only implementation of that API resides in the src/random.xc file. This file explicitly uses XC references in its function signatures. In addition, due to the .xc extension on the source file, the xcc compiler assumes that it contains XC unless overridden by the -x option.

To provide a proper C API, this repository needs an random.c file containing a pure C implementation.

@mbanth mbanth added the type:enhancement New feature or request label Jan 20, 2021
@mbanth mbanth added this to the Ready for Publication milestone Jan 20, 2021
@mbanth mbanth removed this from the Publish Before Resolution milestone Apr 20, 2021
@xross
Copy link
Contributor

xross commented Oct 11, 2024

Using REFERENCE_PARAM should mean it's callable from c, regardless of the implementation language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants