Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YMultiDocUndoManager is not compatible with yjs version above 13.6.12 #8

Open
1 task done
furkan3ayraktar opened this issue Jun 18, 2024 · 3 comments
Open
1 task done
Assignees
Labels
bug Something isn't working

Comments

@furkan3ayraktar
Copy link

Describe the bug
YMultiDocUndoManager clears the entire undo stack instead of popping one when it's used together with yjs version 13.6.13 or any version above that.

To Reproduce
Steps to reproduce the behavior:

  1. Install yjs version 13.6.13 or above
  2. Install y-utility
  3. Create a YDoc and instantiate a YMultiDocUndoManager
  4. Do some operations on the doc and try undoing.
  5. Observe that all operations are undoed instead of the last one

Expected behavior
Only last operation is undoed instead of all operations.

Environment Information

  • Browser [e.g. Chrome]
  • yjs v13.6.18
  • y-utility v0.1.4
  • This issue is a blocker for my project.
@furkan3ayraktar furkan3ayraktar added the bug Something isn't working label Jun 18, 2024
@furkan3ayraktar
Copy link
Author

Related to yjs/yjs#645

dmonad added a commit to yjs/yjs that referenced this issue Jun 18, 2024
@dmonad
Copy link
Member

dmonad commented Jun 18, 2024

Thanks! This is now fixed in the latest Yjs release (Yjs@13.6.18)

@furkan3ayraktar
Copy link
Author

Thank you 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants