-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save Wallet Name and Url Image on creation #245
Comments
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedI have worked on typescript and JS before on various projects and latest I was working with Nethermind on the Voyager starknet block explorer |
@maxslimb if you'd like to tackle this, see https://github.com/yours-org/yours-wallet/blob/main/CONTRIBUTING.md When saving you'll want to do something similar to this to save the name and/or icon in chrome local storage: yours-wallet/src/pages/Settings.tsx Line 223 in 312241c
There are a number of different ways a user can create/import/restore a wallet which can be found here: |
Hi @danwag06, Thanks |
@maxslimb Everything from an account state perspective is stored using chrome storage api. To see this you can open the wallet in your browser window then:
|
@danwag06 I just want to confirm, that we need to save the label which is "Account 1" if I create a new account and the URL image is the image shown near the label, for instance, the small circle. |
Yes correct @maxslimb I should also tell you about a hackathon that's going on where you could get rewarded for this issue. It's happening via a fork of this repo but we plan to merge any changes that come from it. This issue is a part of the hackathon. https://app.onlydust.com/hackathons/odhack-90 The project of interest will be spv-wallet-browser It's starts tomorrow. If I see your application come through I will approve it. |
The wallet currently supports giving different accounts a name (label) and a url icon. The request would be to optionally save this information when creating/restoring/importing the wallet.
The text was updated successfully, but these errors were encountered: