Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ビルド用Workflowの改善 #259

Closed
yutotnh opened this issue Aug 6, 2023 · 0 comments · Fixed by #260
Closed

Feature: ビルド用Workflowの改善 #259

yutotnh opened this issue Aug 6, 2023 · 0 comments · Fixed by #260
Assignees
@yutotnh
Labels
enhancement New feature or request

Comments

@yutotnh
Copy link
Owner

yutotnh commented Aug 6, 2023 •
edited
Loading

なぜ機能が欲しいのか

下記コードは　cd .. でcloneしたリポジトリのディレクトリの1つ上に移動して、ビルドしている

コードから、やっていることとその目的がわかりづらい

spirit/.github/workflows/build.yml

Lines 66 to 68 in a5e80ef

run: |
cd ..
mbed-tools new .

提案の説明

下記ページを参考に、移動を　cd .. ではなく　 cd ${GITHUB_WORKSPACE} とする

その他
@yutotnh yutotnh added the enhancement New feature or request label Aug 6, 2023
@yutotnh yutotnh self-assigned this Aug 6, 2023
yutotnh added a commit that referenced this issue Aug 6, 2023
@yutotnh
chore: ビルドディレクトリへの移動するコマンドを変更 #259
0691868
@yutotnh yutotnh linked a pull request Aug 6, 2023 that will close this issue
chore: ビルドディレクトリへの移動するコマンドを変更 #259 #260
Merged
@yutotnh yutotnh mentioned this issue Aug 6, 2023
Merged
yutotnh added a commit that referenced this issue Aug 6, 2023
@yutotnh
chore: main.cppの位置とspiritディレクトリの位置を別にする #259
156dd32
yutotnh added a commit that referenced this issue Aug 6, 2023
@yutotnh
fix: mbed-cliでmain.cppのコピーのパスが間違っている問題を修正 #259
7dbc044
yutotnh added a commit that referenced this issue Aug 14, 2023
@yutotnh
chore: ビルドディレクトリへの移動するコマンドを変更 #259 (#260)
ff1d5f5 
* chore: ビルドディレクトリへの移動するコマンドを変更 #259

* chore: main.cppの位置とspiritディレクトリの位置を別にする #259

* fix: mbed-cliでmain.cppのコピーのパスが間違っている問題を修正 #259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yutotnh yutotnh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: ビルドディレクトリへの移動するコマンドを変更 #259 yutotnh/spirit
1 participant
@yutotnh