Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with borderless when using default_tab_template with children #3632

Open
aidantlynch00 opened this issue Sep 30, 2024 · 0 comments
Open

Comments

@aidantlynch00
Copy link

Basic information
zellij --version: zellij 0.40.1

stty size: 69 281

uname -av or ver(Windows): Linux halcyon 6.2.15-100.fc36.x86_64 SMP PREEMPT_DYNAMIC Thu May 11 16:51:53 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Further information

Reproduction steps, noticeable behavior, related issues, etc

2. Issues with the Zellij UI / behavior / crash

Issue description

Layouts that define a default_tab_template with a children node will not respect the borderless=true attribute on children nodes. If the same child pane is instead placed in the default_tab_template in place of children, the expected behavior is seen.

Minimal reproduction

The following layout produces the observed behavior:

layout {
    default_tab_template {
        pane borderless=true size=1 {
            plugin location="tab-bar"
        }
        children
        pane borderless=true size=1 {
            plugin location="status-bar"
        }
    }

    tab {
        pane borderless=true
    }
}

image

The next layout produces the expected behavior:

layout {
    default_tab_template {
        pane borderless=true size=1 {
            plugin location="tab-bar"
        }
        pane borderless=true
        pane borderless=true size=1 {
            plugin location="status-bar"
        }
    }

    tab
}

image

Other relevant information

My full layout contains 3 tabs. I have run zellij with this layout many times and usually the pane on the last tab is borderless, however this is not consistent. I have also seen the pane on the 2nd tab be borderless a couple of times. This leads me to believe some race is happening. I have pasted my full layout below for completeness:

layout {
    pane_template name="plain-pane" borderless=true

    default_tab_template {
        plain-pane size=1 {
            plugin location="tab-bar"
        }
        children
        plain-pane size=1 {
            plugin location="status-bar"
        }
    }

    tab name="Code" {
        plain-pane command="nvim"
    }
    
    tab name="Term" focus=true {
        plain-pane
    }

    tab name="Git" {
        plain-pane command="lazygit"
    }
}

Let me know if you would like me to provide more information/examples.

aidantlynch00 added a commit to aidantlynch00/dev-env that referenced this issue Sep 30, 2024
Added a zellij config file and a default layout for development. The
installation of both were added to the install script. The default
layout is quite clunky at the moment due to a bug in zellij 0.40.1 which
I have opened an issue for
(zellij-org/zellij#3632). The layout should be
changed to properly use `default_tab_template` when the issue is
resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant