[Bug 🐞]: Saves take a long time to process

[jlcarneiro]

Brief description of your issue

Saves take a long time do process. A quicksave, for example, took 37 seconds (using a SSD!).

Steps to reproduce

Just load the savegame, go to a flight (probe, rover, ship) and hit F5 (quicksave).
quicksave.zip

Expected behavior

It should save in a few (1-2) seconds.

Actual behavior

Don't know why, DeltaV started to show incorrectly and my saves got bigger and bigger and the saving process took longer.
Downgrading to version 2.2.0.0, solved deltaV problem, but savegame issues persisted.

Environment

ScrapYard and OhScrap! Mod version 2.2.0.0
KSP version 1.12.3
Mods downloaded through Github and SpaceDock and manually installed
[KSP.log](https://github.com/zer0Kerbal/ScrapYard/files/8404849/KSP.log)
[Player.log](https://github.com/zer0Kerbal/ScrapYard/files/8404852/Player.log)

How did you download and install this?

mod_versions.txt

GitHub clone (expert manual installation)

[github-actions]

Thank you. Kindly read contributiing.md, code_of_conduct.md and styleguide.md. These are boilerplate.

[zer0Kerbal]

@jlcarneiro thank you for the bug report!

would you kindly drag and drop your KSP.log here?

[zer0Kerbal]

net-lisias-ksp/KSP-Recall#66

@jlcarneiro

[Lisias]

net-lisias-ksp/KSP-Recall#66

With data missing after rerooting the subassembly, these latencies are most than likely chained try-catches crazily trying to cope with tons of NREs or similar Exceptions.

It's still a theory, as I need to steal time somewhere to redo all that tests again with each Add'On affected - but it's a solid one. At least for now.

[zer0Kerbal]

@Lisias is it solid progress.

Root Cause Analysis is often painfully slow, but it works effectively well.