Expanding keys with lots of subkeys takes a long time and/or hardlocks

[God-damnit-all]

If I attempt to expand HKEY_CLASSES_ROOT (clicking the area in red):

... TotalReg completely freezes. I let it try to do its thing for about 5 minutes before I gave up.

I instead went and expanded HKEY_CURRENT_USER\SOFTWARE\Classes and that did work, but it took a little over a minute.

In regedit, it takes only about a second to do either of these things.

If there's something you need me to do to help debug this, I'd be happy to help. I do have Visual Studio 2022 and could (probably) compile this to use its debugging features, but I'm a novice and you'd need to tell me what steps to take, what lines of code to set a breakpoint at, etc.

Also, even if this is fixed in TotalReg to also be a second or so, it'd be nice if the left pane could run on an asynchronous thread that doesn't lock up the rest of the program while it's expanding a key with lots of subkeys.

[zodiacon]

Yes, it seems it finishes, but it takes too long.
I will investigate.

[zodiacon]

Probably fixed bug. See latest commit.
Thanks!

[God-damnit-all]

Probably fixed bug. See latest commit. Thanks!

Should I compile it or will you be releasing a new version?

[zodiacon]

I've put the binary for now in the AllTools repo.
I will create a new release once I'm sure enough it's good.

[God-damnit-all]

Thank you. Yep, seems to be working!

It's still not as quite as fast as regedit's expansion (it takes a few seconds for HKEY_CLASSES_ROOT), but it's certainly useable now.

[zodiacon]

Yes, I have an idea on how to improve the speed...

[God-damnit-all]

@zodiacon I've been using TotalReg with the change for a bit now, I think it's safe to make a release with it.

[zodiacon]

Thanks! Appreciate the testing.

[God-damnit-all]

@zodiacon Ah hell, figures just hours after I posted that I came across something.

Apparently it still hangs for a really long time when you refresh with F5.

[zodiacon]

I'll look into it.

[God-damnit-all]

I'll look into it.

My sincerest apologies for not catching it before, I wasn't really in a position where I needed to actually continuously check back on changes I'd made, but I was messing around with stuff yesterday related to context menu launchers that's when I noticed it.

Anyway, I downloaded the new build off the AllTools repo, and, with TotalReg's path set to the HKEY_CLASSES_ROOT\LibraryFolder\background\shell Key, when I press F5, it's still exhibiting the same behavior as before, effectively just locking up until the end of time.

[zodiacon]

No need to apologize :)
I believe I fixed it, grab the binary from the AllTools repo.

[God-damnit-all]

No need to apologize :) I believe I fixed it, grab the binary from the AllTools repo.

I'm afraid that's the binary I was referring to, I grabbed it just minutes before I replied just now.

[CSGalloway]

What is the full URL to the AllTools repository? =============== Charles S Galloway

…

On Sun, Jul 30, 2023 at 2:29 PM Pavel Yosifovich ***@***.***> wrote: No need to apologize :) I believe I fixed it, grab the binary from the AllTools repo. — Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAX6VRMPVVDJUNER3CBWFDXS2RWXANCNFSM6AAAAAA2MFZSII> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[zodiacon]

https://github.com/zodiacon/AllTools

[piterq]

I'm experiencing the same behavior as @ImportTaste (using official release binary and AllTools repo binary as well) - pressing F5 on HKEY_CLASSES_ROOT locks up TotalRegistry.

[zodiacon]

Thanks for the report, I will investigate.

[iamqiz]

I meet same question when I expand the "HKEY_CLASSES_ROOT", Version=v0.9.7.5

[zodiacon]

Please try version 0.9.7.6 from the AllTools repo

[iamqiz]

@zodiacon https://github.com/zodiacon/AllTools/releases/tag/v0.9.7.5 ? it work (taking less time to expand HKCR), thanks!

[God-damnit-all]

The Refresh lag is fixed, though I ended up noticing another bug in the process:

#63