Do not panic on wire set twice or generator not run issues
#1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
changed the title
wire set twice or generator not run issues
muursh
approved these changes
Aug 7, 2024
4l0n50
approved these changes
Aug 7, 2024
| ); | ||
| F::ZERO, | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
since IoResult is also a Result, can you map the error instead of panicking?
There was a problem hiding this comment.
it's a unit test, and it doesn't return anything hence why I kept unwrap() (there are some pre-existing ones below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1490
Also allows to address 0xPolygonZero/zk_evm#292.
Given that we already have some breaking changes pending, and this PR would just trigger warnings of unused returned
Resulton projects depending onplonky2, this should be a fairly sane change.Note: I'd recommend reviewing with
hidden whitespaces.