Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge refactoring #35

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Huge refactoring #35

wants to merge 23 commits into from

Conversation

deters
Copy link

@deters deters commented Apr 5, 2018

Hi Lucas,

I did a major refactoring in your project... it's almost a new project, because all methods where promisified... I also added support to playlist manipulation (create, delete, add and remove tracks). One last thing I did was to implement a quota mecanism... I don't expect you to pull the changes because they will break your current projects, but I would like to know if you would like to adopt the code as a new project, or if you can help me to do it...

I changed the search examples and create a new example for playlist manipulation, so you can see how it works... any suggestions are welcome... I'm a beginner in JS development.

Thank you!

Lucas Deters

@deters
Copy link
Author

deters commented Apr 6, 2018

Hi Lucas,

I figured out how easy it was to publish a new project on npm, so I did it already under the name tidalpromise... any suggestions in the code are welcome.

Thank you in advance.

Lucas Deters

@0xVasconcelos
Copy link
Owner

Hi Lucas, amazing work! I'll check better on the next days! I'll contact you.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants