Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] use ros logging #129

Open
fmessmer opened this issue Jan 20, 2017 · 2 comments
Open

[cleanup] use ros logging #129

fmessmer opened this issue Jan 20, 2017 · 2 comments

Comments

@fmessmer
Copy link
Contributor

fmessmer commented Jan 20, 2017

There are quite some nodes using python2 print

./cob_twist_controller/scripts/test/test_raw31.py
./cob_twist_controller/scripts/test/test_careobot_base.py
./cob_twist_controller/scripts/test_publisher_twist_series.py
./cob_twist_controller/scripts/test_publisher_twist_sine.py
./cob_twist_controller/scripts/evaluate_dbg_jnt_velocity_tests.py
./cob_twist_controller/scripts/test_publisher_vel.py
./cob_twist_controller/src/data_collection/data_collection.py
./cob_obstacle_distance/scripts/test_interactive_obstacle_node.py
./cob_frame_tracker/scripts/interactive_frame_target.py
./cob_cartesian_controller/scripts/test_move_lin.py
./cob_cartesian_controller/scripts/test_move_circ.py
./cob_cartesian_controller/src/simple_cartesian_interface/simple_cartesian_interface.py
./cob_model_identifier/scripts/input_series_twist.py

use proper rospy.logXXX (or at least python3-compatible print())

Also get rid of std::cout:

./cob_undercarriage_ctrl_node/src/cob_undercarriage_ctrl_new.cpp
./cob_trajectory_controller/common/include/cob_trajectory_controller/RefValJS_PTP.h
./cob_model_identifier/src/output_recorder.cpp
./cob_collision_velocity_filter/src/cob_collision_velocity_filter.cpp

@fmessmer FYI

@fmessmer
Copy link
Contributor Author

fmessmer commented Jan 20, 2017

This might also be the case in other repos..., e.g.:

  • cob_driver
  • cob_manipulation
  • ...

@mgruhler
Copy link
Contributor

To enforce proper usage of print (if using it at all) in python, there exists:

form __future__ import print_function

See http://wiki.ros.org/python_2_and_3_compatible_code#Print_is_now_a_function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants