DMW-Thesis #15
DMW-Thesis #15
Conversation
…v variable within the new session i.e. for docker names
…th special chars.
Odin-byte
force-pushed
the
feature/prefix_for_multi_robot
branch
from
ea5eb73
to
b5c1539
Compare
| parser.add_argument( | ||
| "-n", | ||
| "--number", | ||
| help="the number to append to each session name within the config file. used for multi robot setups. Can also be used within sessions as a env_variable. this is used as a unique ros domain id", | ||
| default="", | ||
| ) |
There was a problem hiding this comment.
I'm a bit hesitant to just call this number
Maybe we should rather call this session_id_no or session_prefix_no or something
We should maybe also parse this argument as an integer explicitly to have some type checking
It is later used as ROS_DOMAIN_ID - is this really guaranteed to be unique?
There was a problem hiding this comment.
https://github.com/4am-robotics/orga/wiki/ROS-Domain-Ids starts with 7
I'll add reserved for 0-6 so no one is going to assign those ROS_DOMAIN_IDs
👉 https://github.com/4am-robotics/orga/wiki/ROS-Domain-Ids/3025d5cc6f7d29fcc6cc63d32e79c96a6bffd74a
There was a problem hiding this comment.
I would lean towards session_prefix_no
There was a problem hiding this comment.
instance_id it is - as discussed with @Odin-byte
|
the (merge-able) version is provided via #19 |
No description provided.