Skip to content

Commit

Permalink
Merge pull request #314 from 4dn-dcic/1.0.1
Browse files Browse the repository at this point in the history
goofys version update
  • Loading branch information
SooLee authored Feb 4, 2021
2 parents aa38a84 + 8413d81 commit 0d14059
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
4 changes: 3 additions & 1 deletion awsf3-docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,13 @@ RUN export SINGULARITY_VERSION=3.3.0 && \
mv singularity2 singularity

# goofys
RUN curl -O -L http://bit.ly/goofys-latest && chmod +x goofys-latest
# RUN curl -O -L http://bit.ly/goofys-latest && chmod +x goofys-latest # latest is not latest
RUN wget https://github.com/kahing/goofys/releases/download/v0.24.0/goofys && chmod +x goofys

# python packages
RUN pip install boto3==1.15 awscli==1.18.152 botocore==1.18.11
RUN pip install psutil==5.7.3
#RUN pip install schema-salad==2.7.20180514132321 cwltool==1.0.20180525185854 # old set up, doesn't work for python3
RUN pip install schema-salad==7.0.20200811075006 cwltool==3.0.20201017180608
RUN pip install ec2metadata==2.0.1

Expand Down
1 change: 1 addition & 0 deletions awsf3-docker/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ exl echo "## cwltool version $(cwltool --version | cut -f2 -d' ')"
exl echo "## cromwell version $(java -jar /usr/local/bin/cromwell-35.jar --version | cut -f2 -d ' ') for WDL draft2"
exl echo "## cromwell version $(java -jar /usr/local/bin/cromwell.jar --version | cut -f2 -d ' ') for WDL v1.0"
exl echo "## $(singularity --version)"
exl echo "## $(goofys --version 2>&1)"


# getting run.json file
Expand Down
2 changes: 1 addition & 1 deletion awsf3/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def create_mount_command_list(mountlist_filename, runjson_input):
with open(mountlist_filename, 'w') as f:
for b in sorted(buckets_to_be_mounted):
f.write("mkdir -p %s\n" % (INPUT_MOUNT_DIR_PREFIX + b))
f.write("goofys-latest -f %s %s &\n" % (b, INPUT_MOUNT_DIR_PREFIX + b))
f.write("goofys -f %s %s &\n" % (b, INPUT_MOUNT_DIR_PREFIX + b))


def create_download_command_list(downloadlist_filename, runjson_input):
Expand Down
4 changes: 2 additions & 2 deletions tests/awsf3/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,9 @@ def test_create_mount_command_list():
mcfile_content = f.read()

right_content = ('mkdir -p /data1/input-mounted-somebucket\n'
'goofys-latest -f somebucket /data1/input-mounted-somebucket &\n'
'goofys -f somebucket /data1/input-mounted-somebucket &\n'
'mkdir -p /data1/input-mounted-somebucket2\n'
'goofys-latest -f somebucket2 /data1/input-mounted-somebucket2 &\n')
'goofys -f somebucket2 /data1/input-mounted-somebucket2 &\n')

assert mcfile_content == right_content
os.remove(mountcommand_filename)
Expand Down
2 changes: 1 addition & 1 deletion tibanna/_version.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Version information."""

# The following line *must* be the last in the module, exactly as formatted:
__version__ = "1.0.1"
__version__ = "1.0.2"

0 comments on commit 0d14059

Please sign in to comment.