Handle zero mem available correctly in plot_metrics #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-veit
commented
Apr 14, 2023
| @@ -79,8 +79,8 @@ def get_metrics(self, nTimeChunks=1): | |||
| max_disk_space_used_GB_chunks.append(self.max_disk_space_used()) | |||
| max_ebs_read_chunks.append(self.max_ebs_read()) | |||
| self.max_mem_used_MB = self.choose_max(max_mem_used_MB_chunks) | |||
| self.min_mem_available_MB = self.choose_min(min_mem_available_MB_chunks) | |||
| if self.max_mem_used_MB: | |||
| self.min_mem_available_MB = self.get_min(min_mem_available_MB_chunks) | |||
There was a problem hiding this comment.
I am replacing choose_min with get_min here since we want to keep 0.0 in the list. This assumes that we never get None or "" items from CW, which is probably save to assume?
There was a problem hiding this comment.
The problematic case occurred for min_mem_available_MB_chunks = [0.0]. This should now be handled correctly.
willronchetti
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plot metrics currently throws an error when the minimal available memory reported by CW is 0.