Clean up policy templates #5502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deiferni
reviewed
Mar 20, 2019
| @@ -87,7 +87,7 @@ setup.enable_meeting_feature.post_ask_hook = mrbob.hooks:to_boolean | |||
|
|
|||
| setup.enable_docproperty_feature.question = Enable docproperty feature | |||
| setup.enable_docproperty_feature.required = True | |||
| setup.enable_docproperty_feature.default = False | |||
| setup.enable_docproperty_feature.default = True | |||
There was a problem hiding this comment.
we should discuss to flip the default in ITemplateFolderProperties and get rid of this question alltogether.
added 10 commits
March 20, 2019 16:00
|
@phgross this depends on us figuring out how to gain enough confidence to get 4teamwork/gever-buildouts#30 merged. |
|
Outdated, as discussed in the daily, I close this PR . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Depends on 4teamwork/gever-buildouts#30
Closes #5409