Implement schema-intent concept #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasgraf
force-pushed
the
lg-schema-intent
branch
from
7370245
to
3acdec2
Compare
njohner
reviewed
Oct 22, 2019
opengever/api/schema/vocabularies.py
Outdated
| elif len(self.params) == 1: | ||
| # Edit intent | ||
| # - context is the object to be edited | ||
| # - schemata need to be determined via context |
There was a problem hiding this comment.
This comment line is not needed here
opengever/api/schema/vocabularies.py
Outdated
| # Add intent | ||
| # - context is the container where the object will be created | ||
| # - portal_type is the type of object to be created | ||
| # - schemata need to be determined via portal_type |
There was a problem hiding this comment.
This comment line is not needed here
njohner
reviewed
Oct 22, 2019
opengever/api/schema/vocabularies.py
Outdated
| # - portal_type is the type of object to be created | ||
| # - schemata need to be determined via portal_type | ||
| self.intent = 'add' | ||
| portal_type = self.params[0] |
There was a problem hiding this comment.
portal_type is unused here
njohner
force-pushed
the
lg-schema-intent
branch
from
91cdf30
to
63407cb
Compare
|
Current stand:
Then there were some issues with fields of the type type of the keywords which have one more level of nesting (
|
lukasgraf
force-pushed
the
lg-schema-intent
branch
from
e7b3393
to
ca23515
Compare
njohner
reviewed
Nov 1, 2019
|
|
||
| @adapter(ICollection, Interface, IOpengeverBaseLayer) | ||
| @implementer(IJsonSchemaProvider) | ||
| class GEVERCollectionJsonSchemaProvider(CollectionJsonSchemaProvider): |
There was a problem hiding this comment.
😅 When I was looking at this issue I was thinking to myself I don't want to overwrite all these adapters, there must be some easier way....
|
This one is ready for a final review. We decided to not duplicate efforts for documentation, and create it when this finally moves upstream into |
phgross
approved these changes
Nov 4, 2019
opengever/api/schema/vocabularies.py
Outdated
| vocab_name = self.params[0] | ||
| elif len(self.params) == 2: | ||
| # Add intent | ||
| # - context is the container where the object will be created | ||
| # - portal_type is the type of object to be created, not needed here | ||
| # - first parameter is the portal_type, not needed here |
Multivalued fields don't directly have sources themselves, but their items do. We therefore need to handle that case in the @sources and @querysources endpoints, and look for a source on the Choice field used as the value_type for the multivalued field. Similarly we need to construct appropriate URLs during schema serialization for these types of fields: The Choice fields used as the value_type for multivalued fields don't usually have a name. We therefore omit their empty string name from the URL, and instead construct URLs that look like the source was actually on the multivalued fields themselves.
lukasgraf
force-pushed
the
lg-schema-intent
branch
from
ca23515
to
3c929e6
Compare
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the schema-intent concept according to #5973:
@schemaendpoint@sources,@querysourcesand@vocabulariesendpointsTodo:
IDuringContentCreationinterface on the request during add-intent scenariosrestricted_vocab.py@typesneeds to be added to@schemaas well@typesresponses aren't broken in non-backwards compatible ways- [ ] DocumentationObviously the frontend also needs to be adapted to use these new endpoints in their intent-aware ways.