Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 75: Add Consistency Check for Three-Thirds Process #109

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Issue 75: Add Consistency Check for Three-Thirds Process #109

wants to merge 3 commits into from

Conversation

peterprescott
Copy link

No description provided.

@peterprescott peterprescott changed the title Add dummy function, update run logic, update test Issue 75: Add Consistency Check for Three-Thirds Process Oct 12, 2024
@peterprescott peterprescott marked this pull request as ready for review October 12, 2024 14:26
@peterprescott peterprescott mentioned this pull request Oct 12, 2024
Open
@peterprescott
Copy link
Author

@holybiber

@holybiber
Copy link
Contributor

Hi Peter, thank you for your work!
However I realize I shouldn't have given #75 the label "good first issue" - I need to specify more clearly what exactly needs to be tested (and then tests for this need also be added here). The ends_with stuff is already quite good but the starts_with needs to test against the translated page title. So no need for another function should_start_with_str, instead should_start_with needs to be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterprescott @holybiber