This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Build CSS in the library to share between projects #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickoneill
commented
Jun 7, 2018
| ``` | ||
| The styling of these components will need the following import added to the root application's tsx file. | ||
| ``` | ||
| import '@5calls/react-components/lib/index.css'; |
There was a problem hiding this comment.
Correct me if I'm wrong: we're building sass in two places, here and in the parent project. Do these get combined into a single css file by webpack or something as part of the build process?
There was a problem hiding this comment.
The CSS from react-components gets bundled by webpack during the 5calls/5calls build. You can run a build and check it out yourself, but I confirmed that it works.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for comments, thanks @cdoremus
This work is being done against issue #3