Enabling accessibility for slickgrid #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2dbffbe.
fix issue #68 editor with activeRow selection
- GridMenu was not working correctly with multiple grids - Also found event leak, GridMenu should be destroyed on grid destroyed
fix(gridMenu): GridMenu with multiple grids & event leak
bugfix(editor): add a flag to suppress active cell changed on edit #242
- when using checkbox selector as a single row selection, we need a way to hide the "Select All" checkbox - also added getOptions/setOptions to dynamically change options on the fly
…ct-all Feature/checkbox selector hide select all
- exposing the init() function helps dealing with i18n translation without losing any Slick.Event attached like onColumnsChanged
feat(picker): Column Picker expose init to use by translation
JS and HTML are text files, so they should be checked be CRLF for Windows and LF for Linux slick.grid.js was in CRLF
Use text=auto for JS and HTML files
…ec from all trigger calls arg lists as it is added in in the trigger function
- as per @secart suggestion
fix(ie): increase performance in IE, closes #367
* The grid has the right role * Column headers have role columnheader * cells have the role gridcell * The cells have the aria-rowindex and aria-colindex set right.
…us set. This is needed since only one item within a hole data grid should be in the tabbing order. This is needed for screen reader users to beable to jump behind the grid instead of being caught in the grid when tabbing.
…he current active cell having tabindex set to 0. The focus sing stuff had to be removed to prevent hidden UI elements from catching the focus and therefore blindfolding screen reader users.
…reparation for new autosize logic
fix style of undefined rowNode
* Navigation using focus mode of the screenreader reads all contents correct. * Editable cells are correctly announced by the screen reader. * When navigating editing will not be enabled by just visiting the cell since this traps screen reader users. So for editing when navigating via keyboard the user has to press enter. This should also be more convinnient for all users since navigation with the keyboard is not caught by editable cells. * FVor debugging the grid still beeps when navigation changes cells. This will be removed later. * When leaving an editor using enter or escape the next cell or current cell is focussed correctly. Especially the escape key left the focus in nowhere.
…actices: https://www.w3.org/TR/wai-aria-practices/#grid - Especially the grid now moves to the last cell when using Ctrl+End and the first cell when using Ctrl+Pos1
…cell. F2 now also seems to work though there is no special code for that key.
The percent bar complete formatter now sets the value as text within the painted span so screen reader uses get the value read. Using the alt or title attribute didn't work for the screen reader.
…and setting the aprociate role as specified by the WAI. Currently collapsed and expanded rows are not shown correctly but this may be due to example 5 using the collapsing for filtering. In the formatter a Typo has been fixed.
…tor are shown correctly to screen reader users.
…lected attribute set to denote the selection state. Currently the recommended keyboard shortcuts for selecting columns and rows are not implemented and don't work.
…w and column selection as specified by the WAI through Strl+Space and Shft+Space. The selection of columns and rows still doesn't work but removing space from the editing trigger is a prerequisite for that.
|
I'm on board with accessibility changes, but this PR is not clean - it appears to have been created from a repo with significant other changes, and those have leaked into the code. For example, what's up with the TreeColumns? |
|
Hi,
well the fork was made some time ago, but AFAIK I reviewed the changes as best as I could. So I am sorry, if other changes have been leaking into that.
I’ll check the changes again.+
Mit freundlichen Grüßen
Dipl.-Inf (FH)
Heiko Folkerts
Softwareentwicklung und -Design
…--
_______________________________________________________
msg DAVID GmbH · Mittelweg 7 · 38106 Braunschweig
Tel.: +49 531 24379-14
Fax.: +49 531 24379-79
E-Mail: mailto:heiko.folkerts@msg-david.de
WWW: https://www.msg-david.de
Eintragung: Amtsgericht Braunschweig, HRB 3167
Geschäftsführer: Andreas Lehmann, Dirk Schäfer, Dr. Andreas Scholz
_______________________________________________________
Von: Ben McIntyre <notifications@github.com>
Gesendet: Freitag, 21. Juni 2019 02:04
An: 6pac/6pac.github.io <6pac.github.io@noreply.github.com>
Cc: Heiko Folkerts <Heiko.Folkerts@msg-david.de>; Author <author@noreply.github.com>
Betreff: Re: [6pac/6pac.github.io] Enabling accessibility for slickgrid (#1)
I'm on board with accessibility changes, but this PR is not clean - it appears to have been created from a repo with significant other changes, and those have leaked into the code. For example, what's up with the TreeColumns?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AHZOP6GM4DF7VJ2PSMEK7ZLP3QLINA5CNFSM4HZS6XI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYHBXUY#issuecomment-504241107> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHZOP6G6AEPZCDQ46J2SOXLP3QLINANCNFSM4HZS6XIQ> .
|
This reverts commit ee005c5.
- adding some ARIA stuff that was mixed up within the wrong commit that has been reverted.
- Removing debugging function for beeping
- Removing commented out code.
|
Changes have now been cleaned up. A few comments to the changes that are not concerning ARIA roles directly:
|
Drop local .gitignore changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling accessibility so slickgrid conforms to the WAI authoring practices at https://www.w3.org/TR/wai-aria-practices/#grid
The changes don't fully enable accessibility since many things have to me specified by the application using slickgrid but all possible changes within the grid should be applied. In any case the examples for slick grid are very much more accessible with this changes. tested with NVDA latest versin and Firefox.