-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to NC 28 #190
Adapt to NC 28 #190
Conversation
51e0487
to
99fd0d2
Compare
6827640
to
99d3d7f
Compare
5a7cd0e
to
895d7da
Compare
@ACTom The PR is ready, let me know what you think :) |
895d7da
to
f2a97d7
Compare
9dd879b
to
dea164d
Compare
@ACTom can you merge the PR? |
@artonge Hello, I pulled your Git branch, compiled it, and when I try to open the km file in Nextcloud, it prompts 'An internal server error occurred. |
Can you share more information about the error? |
Excuse me, but I'm not an expert in developing web apps. Could you provide some information about how to build this? I used the Makefile to pack the revised code and put it in the nextcloud/apps/ dir, but nothing happens. Tips for those who are struggling with this app: |
Let's keep the comments about the content of the pull request and not about how to install it :). |
GET /apps/files_mindmap/ajax/loadfile?filename=%2FDocuments%2FNew%20mindmap.km&dir=%2FDocuments 400 |
I also pulled the branch and ran make. Copied the executable to my server. I didn't get an error, just didn't get nextcloud to give me the option to create a new mindmap nor open the existing .km files on my server. |
I have the same issue. When the file is in root folder it works fine. But if file is in any folder it gives 'An internal server error occurred'. Creating a new mind map works in any folder. You can edit and save action is fine. When you try to open it, error happens when not in root folder. |
Signed-off-by: Louis Chemineau <louis@chmn.me>
dea164d
to
e832d95
Compare
Thanks for the feedback, the issue is addressed now :) |
For me it works without any errors. I can create-, edit- and open .km files in any folder. node: 'v21.6.1', npm: '10.2.4' ernolf |
Was it the case before? |
OK, I only have 2 shared .km files. That must be why I can't open them. I don't have the button to create a new one, either. @artonge : before that, in NC27, yes, shared km were working. I only have shared mindmap files. Regards |
I can confirm that this works well. I give some more instructions for @michauk (though it won't help you as shared mindmap files are still broken) First uninstall files_mindmap in nextcloud.
This runs npm and takes a while.
The tar.gz is about 60MB large - which is quite heavy. Now you can activate the app in the UI and have it working :) |
Yes absolutely. Example from a Nextcloud 27.1.6 Server: https://global-social.net/s/php-updater-mindmap |
You can try my build: https://help.nextcloud.com/t/nc28-mindmap-km-files-not-working/176809/11?u=ernolf |
Thank you @ernolf , it works like a charm for me, also after upgrading to Why is it so long to accept the fix on the stable branch ?? Well, there is just something missing, I can't choose the name of the file when creating it, it is always |
@artonge : do you have a clue how to fix that? |
The public page uses the legacy file list. So we need to restore the previous way file actions are registered to be compatible with both legacy and post 28 files API. Same thing for the "new file menu" I guess. This will also bring the benefit to keep the compatibility with previous versions of Nextcloud. |
@ernolf Thanks for building. Please consider removing "src node_modules package* vite*" from the package ;) |
I've installed the patch, thanks to @ernolf build. Now waiting for a working solution for shared mind map. Is somebody working on it ? |
Same for me, waiting for a working solution for shared mind map ! |
Hello Every one ! |
hello i have same problem, no possibility share it (with edition) |
The Files API changed a bit in NC v28.
Here are the changes:
vite
to bundle the front-end files. Needed as the new API is available thought the@nextcloud/files
package.jszip
as a dependency inmindmap.js
so it is automatically added to the bundlesetViewerMode
as we do not have any equivalentaddAndFetchFileInfo
toaxios
+emit
to refresh the file list when the viewer is closed.@nextcloud/files
(registerFileAction
andFileAction
)@nextcloud/files
(addNewFileMenuEntry
)Drawback, the app is only compatible with 28. I guess we could make it compatible with previous versions by keeping both API.
Fix #191