Fixing broken tests (Part I) #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ reset regression tests output `molecule_number` > `grain_number` in `statistics` output. + Reset `minicircle_grainstats.cropped_size` as commit 53fd579 set the default `grainstats.cropped_size` to `-1` which broke the tests which were developed using a size of 40.0nm rather than bounding to the image (which is what `-1` does).
ns-rse
added
DNATracing
ns-rse
changed the title
|
With merge of Sylvia's NN there is some issues, I'm not sure if it just needs a pull of her branch and changes? |
…-test-simplification
|
Fixed above - mainly just conflicts between variable names and typehints in geometry.py in which Sylvias' were more explicit. |
|
This looks like a great start to keep things small. I was running the tests but realise they still fail because they have not been addressed here, just terminology and "id's" added which sound like a good idea for diagnosing why. Happy to merge to the main 800 branch |
MaxGamill-Sheffield
merged commit a1bc487
into
maxgamill-sheffield/800-better-tracing
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on getting the existing tests to pass in light of all the changes in
maxgamill-sheffield/800-better-tracing, still a fair bit to go but small Pull Requests are considerably easier and faster to undertake.tests/test_grainstats_minicircle.pymolecule_number>grain_numberinstatisticsoutput.minicircle_grainstats.cropped_sizeas commit 53fd579 set the defaultgrainstats.cropped_sizeto-1whichbroke the tests which were developed using a size of 40.0nm rather than bounding to the image (which is what
-1does).tests/tracing/test_dnatracing_multigrain.pynpt.NDArraytypehints.pytest.param(id="")added.skeletonisation_method="topostats"no longer a valid option todnaTrace()class, so updated, in some places this uses the**dnatracing_configkeyword approach.tests/tracing/test_dnatracing_methods.pypytest.param(id="")added.grain>maskprint()tests/tracing/test_dnatracing_single_grain.pydnatrac.smoothed_grain>dnatrace.smoothed_masktopostats/tracing/dnatracing.pygrain>maskin a number of places.Partially addresses issues detailed in #850.