tests(plotting): revert molecule_number > grain_number in tests #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index column name had been changed from `grain_number` to `molecule_number` which broke many of the tests defined in `tests/test_plotting.py`. This has been reverted.
|
Can this be merged? |
SylviaWhittle
approved these changes
Sep 9, 2024
ns-rse
merged commit 0a51d25
into
maxgamill-sheffield/800-better-tracing
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index column name had been changed from
grain_numbertomolecule_numberwhich broke many of the tests defined intests/test_plotting.py.This has been reverted.
Partially addresses issues detailed in #850.