Fix AAC-LC Specific Config in test vectors to obey ISO+IEC-14496-1:20…

…10 spec. - Resolves both parts A and B in #119 for the test vectors. - Part A: Add missing "expandable" size field to both of the `DecoderConfigDescriptor` and `DecoderSpecificInfo`. - Part B: Flip `DecoderConfigDescriptor` `reserved` bit to 1. - Based on AOMediaCodec/iamf-tools@57324193.
AOMediaCodec · Aug 14, 2024 · 67499cb · 67499cb
1 parent b5f358a
commit 67499cb
Show file tree

Hide file tree

Showing 19 changed files with 1 addition and 1 deletion.
diff --git a/proto/codec_config.proto b/proto/codec_config.proto
@@ -99,7 +99,7 @@ message AacDecoderConfig {
   optional uint32 object_type_indication = 1 [default = 0x40];
   optional uint32 stream_type = 2 [default = 5];
   optional bool upstream = 3 [default = false];
-  optional bool reserved = 4;
+  optional bool reserved = 4 [default = true];  // As per ISO 14496-1:2010.
   optional uint32 buffer_size_db = 5;
   optional uint32 max_bitrate = 6;
   optional uint32 average_bit_rate = 7;

diff --git a/tests/test_000076.iamf b/tests/test_000076.iamf
diff --git a/tests/test_000076_f.mp4 b/tests/test_000076_f.mp4
diff --git a/tests/test_000076_s.mp4 b/tests/test_000076_s.mp4
diff --git a/tests/test_000090.iamf b/tests/test_000090.iamf
diff --git a/tests/test_000090_f.mp4 b/tests/test_000090_f.mp4
diff --git a/tests/test_000090_s.mp4 b/tests/test_000090_s.mp4
diff --git a/tests/test_000091.iamf b/tests/test_000091.iamf
diff --git a/tests/test_000091_f.mp4 b/tests/test_000091_f.mp4
diff --git a/tests/test_000091_s.mp4 b/tests/test_000091_s.mp4
diff --git a/tests/test_000092.iamf b/tests/test_000092.iamf
diff --git a/tests/test_000092_f.mp4 b/tests/test_000092_f.mp4
diff --git a/tests/test_000092_s.mp4 b/tests/test_000092_s.mp4
diff --git a/tests/test_000093.iamf b/tests/test_000093.iamf
diff --git a/tests/test_000093_f.mp4 b/tests/test_000093_f.mp4
diff --git a/tests/test_000093_s.mp4 b/tests/test_000093_s.mp4
diff --git a/tests/test_000094.iamf b/tests/test_000094.iamf
diff --git a/tests/test_000094_f.mp4 b/tests/test_000094_f.mp4
diff --git a/tests/test_000094_s.mp4 b/tests/test_000094_s.mp4