V1.1 test vectors #120
Merged
V1.1 test vectors #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using new field names that remove an uneeded layer of indirection and better match the usage intention. - Update all test vectors to agree wit - Note `test_000060` provides an example with `count_labels > 2`. - Based on AOMediaCodec/iamf-tools@5edf02d.
jwcullen
force-pushed
the
v1_1_test_vectors
branch
2 times, most recently
from
396037f
to
89b9a5c
Compare
- Using new fields that remove an unneeded layer of indirection. - Based on AOMediaCodec/iamf-tools@05c2d58b for `github/aomediacodec/libiamf/v1.0.0-errata`.
- Introduces a variety two audio element tests.
- The Audio Element with ID=300 is based on one of {9.1.6, 1OA, 2OA, 3OA, 4OA, 7.1.4, 5.1.4}.
- The Audio Element with ID=301 is based on one of the `expanded_loudspeaker_layout`s.
- Output layouts always include stereo and often use an additional layout on one of {mono, 3.1.2, 5.1, 5.1.2, 5.1.4, 7.1, 7.1.2, 7.1.4, 9.1.6}.
- Most other properties are the common within this test set.
- Based on AOMediaCodec/iamf-tools@4630a45c8.
…rofile.
- Update protos to allow a reserved profile (255).
- Update protos to support `MixPresentationTags`.
- Several tests use a mix Presentation which works under Base-Enhanced profile:
- Using [3, 28] audio elements.
- Using [19, 28] channels.
- Using `MixPresentationTags` (should be gracefully ignored by older profiles).
- Other tests signal the not-yet-defined profile 255.
- `sine_1500_stereo_48khz_-15dBFS.wav`: A quiet sine wav.
- Based on AOMediaCodec/iamf-tools@62bb73f2
- Based on Immersive_Audio_Container/[240729]IAMF_Ref_SW_V1.1_additional_TCs.xlsx from https://groups.aomedia.org/g/WG-Storage-and-Transport/message/884, but indexed at 0.
jwcullen
force-pushed
the
v1_1_test_vectors
branch
from
89b9a5c
to
f6c1a1a
Compare
- Based on AOMediaCodec/iamf-tools@05c2d58b for `github/aomediacodec/libiamf/main`.
- Include `MixPresentationTags` in bitstream. - Fix `test_000701` and `test_000711` to better align with the v1.1 spreadsheet. - Based on AOMediaCodec/iamf-tools@e7679f31a.
- Recomputed based on matrices updated in AOMediaCodec/iamf-tools@42f4caff89.
|
@felicialim @jwcullen can you resolve the conflict? |
yongmin-kwon
reviewed
Sep 2, 2024
yongmin-kwon
approved these changes
Sep 3, 2024
|
Re-synced with main and ready to merge in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Test Set 6": test_000600 - test_000633 in 0471b3b.
Based on "Set0-Expanded_ "Immersive_Audio_Container/[240729]IAMF_Ref_SW_V1.1_additional_TCs.xlsx"
in this post. Except the tests are indexed so the first one is 600 instead of 601.
A case using 4OA + Top-4Ch was changed to 3OA + Top-4Ch to fit within the 28 channel limit. Similar for another case with 4OA + Top-6Ch.
Another "Test Set 7" is
planned and will be added as commits on this PRtest_000700 - test_000711 in f6c1a1a.This PR is a superset of #116 and should merged after it.