Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Data structure: use real arrays (#62) #88

Closed
wants to merge 13 commits into from
Closed

Data structure: use real arrays (#62) #88

wants to merge 13 commits into from

Conversation

Artoria2e5
Copy link
Contributor

#62

@Artoria2e5
Copy link
Contributor Author

Bai, try to run a basic self-build check..

build/20-ruby.sh Outdated
rm "$PKGDIR/$GEMDIR/cache/$PKGNAME-$PKGVER.gem"
GEMDIR="$(ruby -e'puts Gem.default_dir')"
gem install --ignore-dependencies --no-user-install -i "$PKGDIR/$GEMDIR" -n "$PKGDIR/usr/bin" "$PKGNAME-$PKGVER.gem"
rm -f -- "$PKGDIR/$GEMDIR/cache/$PKGNAME-$PKGVER.gem"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I simply nuke all the cache?

@Artoria2e5 Artoria2e5 added this to the 2.0.0 milestone Mar 22, 2016
pm/dpkg/pack Outdated
DPKGDEBCOMP+="-z6"
fi
}
if [[ " ${DPKGDEBCOMP[*]" == *' '-z* ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf

@Artoria2e5
Copy link
Contributor Author

rebased. still recommending pull --rebase=preserve origin data.

@Artoria2e5
Copy link
Contributor Author

Well, OK, f that, I forgot to check the args in arch/_common.

@Artoria2e5
Copy link
Contributor Author

Since the flags are exported into ENV in the traditional sloppy way anyway, there is no point in array-izing it for now.

@jyhi
Copy link
Contributor

jyhi commented Mar 5, 2017

How is this PR now?

@Artoria2e5
Copy link
Contributor Author

Changes required for merging should be still obvious.

@Artoria2e5
Copy link
Contributor Author

Oh. The flags internal part (nolto, usexxx etc) needs some data sanitization too.

@Artoria2e5
Copy link
Contributor Author

Artoria2e5 commented Jun 21, 2023

lmao this isn't going anywhere. Anyways, just came up with these snippets:

is_array() { [[ $(declare -p $1) == 'declare -'[aA]* ]]; }
to_array() {
  declare -n ref=$1
  mapfile -d ' ' -t $1< <(printf %s "$ref")
}
check_type_array() {
  if ! is_array "$1"; then
    ab_warn "$1 should be an array now! splitting."
    to_array "$1"
  fi
}

@MingcongBai
Copy link
Contributor

This has stalled for way too long and requires quite a bit of work still. Let's resurrect this when we feel up for it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants