fix Button.js: put an undefined-check for TouchableNativeFeedback #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alvaromb: could you merge this minor commit? Thanks. |
|
Hi @ngduc! Please be patient, I want to check why the tests are failing. Thanks. |
|
@alvaromb The failed tests may be related to this - jestjs/jest#1840 Have you tried this?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
I'm using "react-native-web" & "react-native-gifted-form" which has "APSL/react-native-button" as a dependency.
I think because in web mode, TouchableNativeFeedback is undefined, it crashed my app.
I just added an undefined-check for TouchableNativeFeedback.
Please merge. Thanks.