-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the release notes for Function Multi Versioning. #306
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -360,9 +360,10 @@ Armv8.4-A [[ARMARMv84]](#ARMARMv84). Support is added for the Dot Product intrin | |
* Added the [Keyword attributes](#keyword-attributes) section. | ||
* Changed the [SME language extensions](#sme-language-extensions-and-intrinsics) | ||
to use keyword attributes instead of GNU-style attributes. | ||
* Added missing word to Function Multi Versioning's [Name mangling](#name-mangling). | ||
* Added description of SVE reinterpret intrinsics. | ||
* Changes and fixes for [Function Multi Versioning](#function-multi-versioning): | ||
* Changed the mangling rules [Name mangling](#name-mangling), such that | ||
feature names are appended in lexicographic order, not in priority order. | ||
* Added [MOPS](#memcpy-family-of-operations-intrinsics---mops). | ||
* Align priorities to account for feature dependencies. | ||
* Introduce alternative names (aliases) `rdma` for `rdm`. | ||
Comment on lines
367
to
369
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make sure that all verb formats are consistent: Aligned |
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was unnecessary. IMO typos and minor syntactive improvements don't need to be release noted. Also I believe grouping all the changes to Function Multi Versioning under the same bulletpoint helps readability. If you insist on keeping it can we please move it down with the rest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good point. Let's follow your suggestion and have it removed.