Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FMV] Unify ls64, ls64_v and ls64_accdata. #346

Merged
merged 1 commit into from
Sep 12, 2024

Commits on Sep 12, 2024

  1. [FMV] Unify ls64, ls64_v and ls64_accdata.

    As originally discussed in ARM-software#315 and then in ARM-software#329 we want to unify
    features that the toolchains cannot support independently. In the
    case of ls64 I have attempted to split the lumped feature in the
    compiler (see llvm/llvm-project#101712),
    but unfortunately this would break backwards compatibility:
    
    Mapping 'ls64' to FeatureLS64_ACCDATA would enable all three of
    {FeatureLS64, FeatureLS64_V, FeatureLS64_ACCDATA} but then using
    'nols64' either on the command line or the assembler directive
    would only disable FeatureLS64_ACCDATA without disabling the
    other two. For that we would have to map 'ls64' to FeatureLS64,
    but then it would not enable the other two.
    
    As far as I am aware there are no hardware implementations out
    there which implement ls64 without ls64_v or ls64_accdata, so
    unifying these features in the specification should not be a
    regression for feature detection. If any of this changes in
    the feature we can revisit the specification.
    labrinea committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    35435ef View commit details
    Browse the repository at this point in the history