feat(tests): add CI smoke tests for local-execute examples (#237) - #315
Merged
rosspeili merged 4 commits intoAug 28, 2026
Merged
Conversation
Add tests/test_examples_smoke.py covering 8 offline demo scripts, document example smoke layer in docs/TESTING.md, and record in CHANGELOG.md.
4 tasks
Contributor
|
Nice work @tusharjamunkar, this matches #237 well, and the parity test is a good guard. Before merge, please:
LGTM once the above are fized, thanks! <3 |
- Removed UTF-8 BOM from tests/test_examples_smoke.py - Added note in examples/README.md linking docs/TESTING.md - Tightened expected smoke markers for bg_remover_demo.py
Contributor
Author
|
Thanks for the review, @rosspeili! All 3 items are addressed:
All 18 tests and lint checks are passing cleanly! |
Contributor
Author
|
Also applied �lack formatting to ests/test_examples_smoke.py to satisfy CI style checks cleanly. |
Contributor
|
LGTM @tusharjamunkar, merged. <3 Thanks for this. |
Contributor
Author
|
Thanks so much @rosspeili! Glad I could contribute. <3 |
Contributor
|
You can pick more good first issues or if you're specifically interested in tests, I would check issues around CLI, Examples, and Testing. Welcome @tusharjamunkar 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #237.
Summary
Adds automated CI smoke testing for local-execute offline demo scripts under
examples/. This provides a regression safety net catching import breaks,SkillLoaderdispatch regressions, and manifest errors without requiring live API keys or making external network requests.Key Changes
tests/test_examples_smoke.py:mental_coach_demo.pyprompt_injection_firewall_demo.pyprompt_compression_demo.pydeceptive_ui_guard_demo.pytoken_limiter_loop.pyuk_companies_house_handler_demo.pygmail_handler_demo.pybg_remover_demo.pytest_every_example_script_has_smoke_or_skip_classificationensuring all scripts inexamples/are categorized with explicit skip rationales or smoke test coverage.docs/TESTING.md: Updated status table and four-layer test architecture documentation to document the CI example smoke layer and clarify the skip policy for live model provider loops.CHANGELOG.md: Added user-facing entry under[Unreleased].Verification
pytest tests/test_examples_smoke.py -v: 9 passed in 11.5s.pytest tests/test_registry_docs.py: passed cleanly.flake8 tests/test_examples_smoke.py: 0 errors.