Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/forgetpw #266

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Feature/forgetpw #266

merged 6 commits into from
Oct 13, 2023

Conversation

pipaLU
Copy link
Contributor

@pipaLU pipaLU commented Oct 6, 2023

Description

Allow existing user to reset password.

Fixes # (issue)
Issue in user setting edit
Issue in rack info edit (in the default site/ shelf location)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@KeironO
Copy link
Collaborator

KeironO commented Oct 13, 2023

I've taken a look at the code, and it seems fine.

The only issue here is that last time we had a reset password thing as an user-facing function we got spammed to hell and back with people trying to get the system to send a password reset to their email.

Is this something we want to open again?

@pipaLU
Copy link
Contributor Author

pipaLU commented Oct 13, 2023

The only issue here is that last time we had a reset password thing as an user-facing function we got spammed to hell and back with people trying to get the system to send a password reset to their email.
This has been tested without any spams for me, this might be due to the use of 2-step password setting for the email server or the use of an API key for the application when sending emails?

@KeironO
Copy link
Collaborator

KeironO commented Oct 13, 2023

Fair. Will merge

@KeironO KeironO merged commit 0920fb9 into dev Oct 13, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants