This repository has been archived by the owner on Feb 21, 2020. It is now read-only.
Adding a pre-requisites module and core components #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a prereqs module. Moved acs commons subpackage out of ui.apps into prereqs
Update ACS AEM Commons to latest version
|
I like this idea, but should it be an option to create it? |
|
Hmmm. If it's an option and the user choose no, then fall back to ui.apps? Yeah, I guess. If you want a super simple setup, that makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most AEM projects we typically have multiple app modules. Adding a pre-requisites module that contains sub-packages and embedded bundles is a way of keeping the application code away from the third-party embeds.
A good example is the Netcentric ACL tool where it installs a hook that needs to be called to apply ACLs. If this hook is not yet installed when the app package installs, the app package installation fails and requires a re-run of the package install.
Also adding core components as an option and updating the ACS AEM commons version.