Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating schemas #215

Merged
merged 3 commits into from
Oct 10, 2023
Merged

updating schemas #215

merged 3 commits into from
Oct 10, 2023

Conversation

jhadobe
Copy link
Contributor

@jhadobe jhadobe commented Oct 10, 2023 •
edited
Loading

Purpose of this pull request

This PR updated the REST and GraphQL schemas to 2.4.7-beta2.

Pages affected

Staging

@jhadobe jhadobe added the major-update Significant updates to content label Oct 10, 2023
@jhadobe jhadobe self-assigned this Oct 10, 2023
@jhadobe jhadobe added internal Differentiates work between community and Adobe staff 2.4.7 labels Oct 10, 2023
@jhadobe
Copy link
Contributor Author

jhadobe commented Oct 10, 2023

Sanity check

Checking against changelog

REST

import/json - https://github.com/AdobeDocs/commerce-webapi/pull/215/files#diff-1b2a23bf3c01276ca2761e7c8ef22ae79acc726379b7273dcc1b17b89541b316R10677

GraphQL

cancelOrder - https://github.com/AdobeDocs/commerce-webapi/blob/b83c70e01f2125208b01c29b3114b31421d74f1e/spectaql/schema_beta.json#L2079

attributesForm - https://github.com/AdobeDocs/commerce-webapi/blob/b83c70e01f2125208b01c29b3114b31421d74f1e/spectaql/schema_beta.json#L17

attributesList - https://github.com/AdobeDocs/commerce-webapi/blob/b83c70e01f2125208b01c29b3114b31421d74f1e/spectaql/schema_beta.json#L48

cart - https://github.com/AdobeDocs/commerce-webapi/blob/b83c70e01f2125208b01c29b3114b31421d74f1e/spectaql/schema_beta.json#L112

customAttributeMetadataV2 - https://github.com/AdobeDocs/commerce-webapi/blob/b83c70e01f2125208b01c29b3114b31421d74f1e/spectaql/schema_beta.json#L453C1-L453C1

@jhadobe jhadobe marked this pull request as ready for review October 10, 2023 14:49
dshevtsov
dshevtsov reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhadobe please add a link to Pages or Staging preview

jeff-matthews
jeff-matthews reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the "Sanity check" comment!

The only thing that I think needs to be updated is the version in the spectaql config: https://github.com/AdobeDocs/commerce-webapi/blob/main/spectaql/config_beta.yml#L384

@jhadobe
Copy link
Contributor Author

jhadobe commented Oct 10, 2023

I love the "Sanity check" comment!

The only thing that I think needs to be updated is the version in the spectaql config: https://github.com/AdobeDocs/commerce-webapi/blob/main/spectaql/config_beta.yml#L384

updated in latest commit

@jhadobe
Copy link
Contributor Author

jhadobe commented Oct 10, 2023

@jhadobe please add a link to Pages or Staging preview

added to description

jeff-matthews
jeff-matthews approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange to see customer schema changes in the file list but that it didn't trigger a preview. But all looks good to me.

dshevtsov
dshevtsov approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have access to the preview on redoc.ly. GraphQL looks good.

keharper
keharper reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your Sanity Check section means I don't have much to do here. Great job.

@jhadobe
Copy link
Contributor Author

jhadobe commented Oct 10, 2023

Strange to see customer schema changes in the file list but that it didn't trigger a preview. But all looks good to me.

Yes, i'm not sure why it isn't triggering, when the other schemas did. i'll double check it once it is published.

@jhadobe jhadobe merged commit 5acde02 into main Oct 10, 2023
20 checks passed
@jhadobe jhadobe deleted the jh_schemas branch October 10, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keharper keharper keharper left review comments

@dshevtsov dshevtsov dshevtsov approved these changes

@jeff-matthews jeff-matthews jeff-matthews approved these changes

Assignees

@jhadobe jhadobe

Labels
2.4.7 internal Differentiates work between community and Adobe staff major-update Significant updates to content
Projects
Commerce - Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhadobe @keharper @dshevtsov @jeff-matthews