Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve comments heuristic #389

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Improve comments heuristic #389

wants to merge 5 commits into from

Conversation

Nadrieril
Copy link
Member

@Nadrieril Nadrieril commented Oct 1, 2024 •
edited
Loading

Fixes #388.

@Nadrieril Nadrieril marked this pull request as draft October 1, 2024 09:23
@msprotz
Copy link
Contributor

msprotz commented Oct 1, 2024

FYI, just gave this a quick try, and I don't seem to be receiving the comments at all anymore (or at least, the one I noticed had a problem)

@Nadrieril
Copy link
Member Author

Nadrieril commented Oct 1, 2024 •
edited
Loading

Yeah I marked it as draft because it doesn't work for complex cases such as destructuring or assert! that you test in Eurydice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suboptimal placement of comment
2 participants
@Nadrieril @msprotz