Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): add file output option for logging configuration #1167

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(logging): add file output option for logging configuration #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bce0b4a
feat(logging): add file output option for logging configuration
skrashevich Jun 6, 2024
e46fc13
fix(log): ensure fallback to stdout if log file open fails
skrashevich Jun 6, 2024
ac798d9
fix(log): handle log file open error by writing to stdout
skrashevich Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,6 +1213,7 @@ log:
rtsp: warn
streams: error
webrtc: fatal
output: stdout # Available output options are: stdout, stderr, or a file path.
```

## Security
Expand Down
14 changes: 14 additions & 0 deletions internal/app/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,20 @@ func NewLogger(config map[string]string) zerolog.Logger {
writer = os.Stderr
case "stdout":
writer = os.Stdout
case "file":
filePath := config["file"]
if filePath == "" {
filePath = "go2rtc.log"
}
file, err := os.OpenFile(filePath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
if err != nil {
os.Stdout.WriteString("Error: Failed to open log file: " + err.Error() + ". Log output is set to stdout now.\n")
writer = os.Stdout
} else {
writer = file
}
default:
writer = os.Stdout
}

timeFormat := config["time"]
Expand Down