Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nest: add support for RTSP cameras #1253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jamal
Copy link

@jamal jamal commented Jul 12, 2024

Add support for RTSP cameras for Nest. The protocol information is carried in the stream URL, to avoid having to make a call to resolve the device when a stream is started. The same logic for extending the stream is used, but StreamExtensionToken is used when it's an RTSP stream.

@AlexxIT AlexxIT self-assigned this Jul 12, 2024
@felipecrs
Copy link
Contributor

This is nice, drops the need of https://github.com/felipecrs/hass-expose-camera-stream-source for these cameras.

@felipecrs
Copy link
Contributor

felipecrs commented Jul 12, 2024

Although I suppose users still has to provide their own authentication details instead of having them fetched from Home Assistant, right? (which would make total sense).

@jamal
Copy link
Author

jamal commented Jul 12, 2024

I didn't look at the Hass integration works so unsure if it will properly fetch credentials. I suppose if it works with the WebRTC cameras that it should work with this change as well, as any changes I made happen after the Nest API is initialized.

I guess one issue may be with the stream URL expecting a protocol parameter. I updated the logic that generated the URL in the "Add" tab of the UI to include this. I can take a look at that later today to make sure it works properly.

@RobotTheMLG
Copy link

Any news on this? I think I saw a comment on a different issue saying that work on Nest-integrated cameras had been abandoned. This was particularly difficult for me since I have a Nest Doorbell Wired Camera (1st gen) that supports RTSP stream only. I saw https://github.com/felipecrs/hass-expose-camera-stream-source was recommended by you @felipecrs on various other issues. But, I managed to utilize the RTSPtoWebRTC integration, setting up the RTSP server on the same port as go2rtc, to add my Nest Doorbell camera to go2rtc. Could this a good alternative to the expose camera source?

@T3chArmy
Copy link

T3chArmy commented Sep 9, 2024

@RobotTheMLG The Nest Doorbell Gen1 supports WebRTC now. just upgraded mine a couple weeks ago. It's now working in Frigate through latest release of Go2RTC.

I suggest you double check the Nest/Google Home app to see if you can upgrade yours.

Source: https://developers.google.com/nest/device-access/release-notes#legacy_camera_migration

@RobotTheMLG
Copy link

@RobotTheMLG The Nest Doorbell Gen1 supports WebRTC now. just upgraded mine a couple weeks ago. It's now working in Frigate through latest release of Go2RTC.

I suggest you double check the Nest/Google Home app to see if you can upgrade yours.

Source: https://developers.google.com/nest/device-access/release-notes#legacy_camera_migration

Are you sure you have the Nest Doorbell 1st gen (Formally Nest Hello)? I believe that documentation is referring to the current Nest Wired Doorbell (2nd gen).

@T3chArmy
Copy link

T3chArmy commented Sep 9, 2024

Screenshot_20240909-111346~2.png

Yes, It's an original Nest Hello.

@felipecrs
Copy link
Contributor

https://developers.google.com/nest/device-access/supported-devices

This page still says that Nest Hello is RTSP-only. But it may just be outdated.

If there are no more devices that are RTSP-only, maybe this PR is unnecessary then.

@trvrnrth
Copy link

trvrnrth commented Sep 9, 2024

For my 1st gen Nest Hello I have a Google Home app notification which reads as follows:

nest cameras launched before autumn 2021 don't support the new camera controller experience in the Google Home app. This will be supported soon.

I've only just enrolled in the Public Preview so I don't know if that's a recent announcement or what "supported soon" will turn out to mean in terms of functionality or timescale.

@jamal
Copy link
Author

jamal commented Sep 9, 2024 via email

@RobotTheMLG
Copy link

I believe I found a useful article by Google on this specific process: https://support.google.com/googlenest/answer/13038234?hl=en

I mistakenly believed that I had "migrated" because my Nest Hello camera appeared in Google Home but that is incorrect. These specific steps actually need to be taken to "migrate" the camera.

A potential problem would be users that wish to keep utilizing the Nest app to manage their camera.

@felipecrs
Copy link
Contributor

felipecrs commented Sep 9, 2024

A potential problem would be users that wish to keep utilizing the Nest app to manage their camera.

Right. I guess @AlexxIT has to decide now.

Worst case users can still use https://github.com/felipecrs/hass-expose-camera-stream-source to import their RTSP-only Nest cameras into go2rtc.

@michaelarnauts
Copy link

Not sure what I'm missing, but I have an first gen Nest Hello with a Nest Aware subscription, but I don't have the option to migrate in the Nest app.

I'm in the Public Preview of the Home app for a long time.

Maybe it's region related, since I'm in Europe.

@trvrnrth
Copy link

For my 1st gen Nest Hello I have a Google Home app notification which reads as follows:

nest cameras launched before autumn 2021 don't support the new camera controller experience in the Google Home app. This will be supported soon.

I've only just enrolled in the Public Preview so I don't know if that's a recent announcement or what "supported soon" will turn out to mean in terms of functionality or timescale.

Seems like my enrollment to the Public Preview may have just been taking a while. I have now successfully migrated my 1st gen Nest Hello and have it hooked up to Home Assistant and streaming into frigate via go2rtc without any apparent issues so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants