Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for xtend_tuya #1412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

azerty9971
Copy link

This PR adds support for Tuya IPC camera using xtend_tuya as a WHEP gateway.

Please don't hesitate to refactor anything that you feel is badly written, I'm not at all a GO developer but I tried my best to keep the code as clean as I could :).

If you want to test this yourself, don't hesitate to contact me at devun999999@gmail.com

This should fix the issue #1345 and is related to issue #315 and PR #1379

Don't hesitate to make any comment.

Have a nice day,
Azerty

This PR adds support for Tuya IPC camera using xtend_tuya as a WHEP gateway.
@felipecrs
Copy link
Contributor

felipecrs commented Oct 28, 2024

My opinion:

go2rtc supports importing WebRTC cameras from Home Assistant through the hass source (check here).

It would be nice if xtend_tuya added this WebRTC support through Home Assistant's standards, hoping that maybe go2rtc's hass source would pick it up without needing an extra source.

Code-wise I know nothing about this, so maybe this comment is completely irrelevant.

In case it is relevant: Home Assistant is overhauling their WebRTC implementation, going away from rtsp_to_webrtc in favor of having go2rtc bundled and even enabled by default in 2024.11.0. Maybe it's better to wait for it before start implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants