-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Abode IOTA via HomeKit #1429
base: master
Are you sure you want to change the base?
Conversation
…th values would fail, example is Abode IOTA gives 0xff0x00 in between other TLV8's
I'm not sure your TLV changes don't break anything. |
I’m not either lol but I did run through pairing which has TLVs larger than 255 bytes and that worked fine and I’m pretty familiar with HAP as I originally patched the PDU fragmentation issue that prevented certain BLE devices from functioning properly with the lib so I am fairly confident this change is solid. |
Oh, great. I wrote that code completely blind. Just on a guess as to how it should work. |
@AlexxIT I'm looking more into the HomeKit side and wanted to get your thoughts on some things. My camera has two instances of the CameraRTPStreamManagement service and there actually is a difference in the video and audio formats offered on them. My thought is it would be nice to be able to specify the iid in the configuration to force it to use the specific service as their streaming statuses do appear to accurately reflect which one is in use. The other thing I was looking at is allowing the user to specify the max width and max height to try to cap out the highest negotiated resolution. The idea with this would be for use with Frigate where I may want one stream to be lower resolution for detect and a higher resolution for record. The last thing I was looking at is two way audio to the homekit device. It looks like there's a handful of scenarios to differentiate around it
|
I'm also interested in two-way audio. I haven't tested it yet, but do native homekit cameras with two-way audio proxied from go2rtc to homekit still have a working talkback button? In the case of non-native homekit cameras with two-way audio, like a tapo camera, there is no talkback button, right? |
Fixes #1295
This adds the ability to discover the Abode IOTA and pair it over HomeKit. It also fixes the TLV8 parsing that would make this particular camera fail to playback due to it producing 0xff, 0x00 in between it's TLV's. I updated the TLV8 parsing to handle scenarios like this generically because in this case 0xff is type 255 with length 0 so you can just handle them like normal 0 length TLV's and move on.