[ALICE3] Added Multiplicity estimator task for ALICE3 - #17540
Open
axti98 wants to merge 8 commits into
Open
Conversation
|
O2 linter results: ❌ 58 errors, |
Please consider the following formatting changes to AliceO2Group#17540
axti98
marked this pull request as ready for review
August 21, 2026 12:46
axti98
requested review from
alibuild,
hscheid,
jesgum and
njacazio
as code owners
August 21, 2026 12:46
njacazio
reviewed
Aug 21, 2026
| trackParCov.getSigma1Pt2()); | ||
| tableMcTrackLabels(trackParCov.mcLabel, 0); | ||
| tableTracksExtraA3(trackParCov.nSiliconHits, trackParCov.nTPCHits, trackParCov.trackType); | ||
| tableTracksExtraA3(trackParCov.nSiliconHits, trackParCov.nTPCHits, trackParCov.trackType, true); |
Collaborator
There was a problem hiding this comment.
shouldn't it be only if the track is a contributor?
Contributor
Author
There was a problem hiding this comment.
Yes, I think I misunderstood something earlier. I have implemented it now that every track that contributed has a flag now which is checked in the table filling
njacazio
reviewed
Aug 21, 2026
|
|
||
| auto charge = 0.; | ||
| auto* p = pdg->GetParticle(mcParticle.pdgCode()); | ||
| if (p != nullptr) { |
Collaborator
There was a problem hiding this comment.
for counting particles we can use https://github.com/AliceO2Group/O2Physics/blob/master/PWGLF/Utils/inelGt.h#L96
Contributor
Author
There was a problem hiding this comment.
I count it in several eta intervals, I would not use this function since then we have to loop again for each eta interval over all tracks which is quite inefficient?
njacazio
reviewed
Aug 21, 2026
| multMC(numMCParticles, numMCParticlesEta25, numMCParticlesEta125, numMCParticlesEta09); | ||
| } | ||
|
|
||
| void processDummy(const aod::Collision&) |
Collaborator
There was a problem hiding this comment.
why do you need the dummy?
Contributor
Author
There was a problem hiding this comment.
Its sometimes more convenient on hyperloop to have a dummy process so you don't need to remove the task all the time
Collaborator
|
Error while checking build/O2Physics/code-check for 2427e80 at 2026-08-21 15:01: Full log here. |
…nto Alice3MultDev Merge auto-format suggestion
Collaborator
|
Error while checking build/O2Physics/staging for a8c7c4f at 2026-08-24 12:48: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 5cdbb84 at 2026-08-24 17:00: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added basic multiplicity estimator task in preparation for PbPb studies and multiplicity dependent studies. Currently, two estimator types are implemented:
Necessary changes in the TrackingTranslator because of data model change as well as in OTF Tracker