Skip to content

[PWGLF] Updates on a structure of resonanceModuleInitializer - #17575

Open
mjkim525 wants to merge 3 commits into
AliceO2Group:masterfrom
mjkim525:codex/module-initializer-update
Open

[PWGLF] Updates on a structure of resonanceModuleInitializer#17575
mjkim525 wants to merge 3 commits into
AliceO2Group:masterfrom
mjkim525:codex/module-initializer-update

Conversation

@mjkim525

Copy link
Copy Markdown
Contributor

Summary

This PR fixes an incorrect daughter-table grouping and the resulting CPU-time regression in resonanceModuleInitializer.

Previously, the modular initializer used the reduced ResoCollision as the grouping key, while Track, V0, and Cascade candidates still referenced the original aod::Collision. As a result, the original collision association was not available to the framework grouping mechanism. This could cause the full filtered Track table to be processed for every reduced collision, producing incorrect cross-collision associations and unnecessary CPU overhead.

Changes

  • Preserve the existing two-stage module-initializer architecture.
  • Add a association between each reduced ResoCollision and its original aod::Collision.
  • Use the original collision as the grouping key in the daughter initializer.
  • Retrieve the corresponding reduced collision through a SmallGroups association.
  • Apply automatic collision grouping to Track, V0, and Cascade candidates.

Preserve the existing reduced-collision link schema while adding a canonical original-collision association for GroupSlicer. Add hybrid Track, V0, and cascade daughter paths that use automatic original-collision grouping and retain the current paths for comparison.
Remove the duplicate processDataOptimized switch and let processDataHybrid own the original-collision grouping implementation directly. Keep process validation and pair-gate diagnostics aligned with the consolidated path.
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 28 warnings, 🔕 2 disabled

@github-actions github-actions Bot changed the title Updates on structure of resonanceModuleInitializer [PWGLF] Updates on structure of resonanceModuleInitializer Aug 24, 2026
@mjkim525
mjkim525 marked this pull request as ready for review August 24, 2026 11:52
@mjkim525 mjkim525 changed the title [PWGLF] Updates on structure of resonanceModuleInitializer [PWGLF] Updates on a structure of resonanceModuleInitializer Aug 24, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5060d6e at 2026-08-24 16:05:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants