Skip to content

[PWGUD] Split tables to 4 and 6 tracks - #17576

Merged
rolavick merged 2 commits into
AliceO2Group:masterfrom
amatyja:master
Aug 24, 2026
Merged

[PWGUD] Split tables to 4 and 6 tracks#17576
rolavick merged 2 commits into
AliceO2Group:masterfrom
amatyja:master

Conversation

@amatyja

@amatyja amatyja commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Split tables to store 4 and 6 tracks separately
Increase the size of efficiency histograms to TH1D

@github-actions github-actions Bot changed the title Split tables to 4 and 6 tracks [PWGUD] Split tables to 4 and 6 tracks Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@amatyja
amatyja marked this pull request as ready for review August 24, 2026 12:10
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9fb069c at 2026-08-24 15:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 224 warnings.'
Found 6 errors and 224 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/9677fb6237501834b81b74fd0d26b885c4a1dbfc/O2Physics-code-check/errors.txt
PWGUD/TableProducer/tauThreeProngEventTableProducer.cxx:310:84: error: the parameter 'p' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/TableProducer/tauThreeProngEventTableProducer.cxx:310:144: error: the parameter 'p1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/TableProducer/tauThreeProngEventTableProducer.cxx:460:34: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/TableProducer/tauThreeProngEventTableProducer.cxx:560:79: error: the parameter 'requiredLayers' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/TableProducer/tauThreeProngEventTableProducer.cxx:592:56: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGUD/TableProducer/tauThreeProngEventTableProducer.cxx:1219:9: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
++ [[ 224 -gt 0 ]]
++ cat /sw/BUILD/9677fb6237501834b81b74fd0d26b885c4a1dbfc/O2Physics-code-check/warnings.txt
PWGUD/DataModel/TauThreeProngEventTables.h:65:34: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:66:34: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:67:34: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:68:38: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:69:40: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:70:38: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:71:40: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:72:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:73:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:74:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:75:40: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:77:48: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:78:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:79:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:80:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:81:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:82:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:83:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:84:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:85:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:86:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:87:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:88:52: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:89:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:92:36: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:93:36: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:94:36: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:95:40: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:96:42: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:97:40: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:98:42: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:99:46: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:100:46: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TauThreeProngEventTables.h:101:46: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
[0 more errors; see full log]

Full log here.

@rolavick

Copy link
Copy Markdown
Collaborator

It's approved, but please consider the performance improvements suggested by the code-checker for the next time.
Roman

@rolavick
rolavick merged commit 85071ba into AliceO2Group:master Aug 24, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants